All Projects Gameplay + OpenGL Software Renderer zdoom.org (Site)

View Issue Details

Jump to NotesIssue History
IDProjectCategoryView StatusDate SubmittedLast Update
0000622Gameplay + OpenGL(No Category)public2017-04-23 12:182017-04-23 15:44
ReporterNinjamander 
Assigned To 
PrioritynormalSeveritymajorReproducibilityalways
Status closedResolutionno change required 
PlatformPCOSWindowsOS Version7
Summary0000622: Exit portal behavior change since zdoom 2.6 and + prevent the player from exiting the map
DescriptionI am not sure exactly what is going on but the way exit portal work seem to have change in gzdoom itself, breaking a few old mod that I dust off for fun.

however, they seem to work fine if you use ZDoom 2.5.0 and lower. They also seem to work find in Zandronium 2.1.2 ut not if you use any of the alpha 3.x.

I try testing those using gzdoom 1-8-02. 1-8-06 and even 2.4.0 and the result is all the same, you can't exit the level.
Steps To ReproduceJust load the wad exitBug.wad and reach the portal entrance (thanks to Torr Samaho for creating this example)

you should be able to exit if you use zdoom 2.5.0 and lower.
Additional Informationadditional information : https://zandronum.com/tracker/view.php?id=3073
TagsNo tags attached.

Relationships

Activities

Ninjamander

Ninjamander

2017-04-23 12:18

reporter  

exitBug.wad (2,984 bytes)
_mental_

_mental_

2017-04-23 14:09

developer   ~0001537

To "fix" this map in recent versions of (G)ZDoom you need to enable 'Non-blocking lines can be pushed' compatibility option or just set compat_pushwindow CVAR.
For already released maps there is the corresponding flag named disablepushwindowcheck for compatibility.txt file.

Let's wait for Graf's opinion, maybe he will add something.
Graf Zahl

Graf Zahl

2017-04-23 14:13

administrator   ~0001538

I have nothing to add. If this is work in progress, change it, if it is a problem for some released mod, post a link to the mod plus the affected map so that a compatibility option can be added.

Sadly, this is one of Randi's ill-advised changes that were made far too frequently when people reported 'bugs'. I hope this stuff will never happen again in the future.
Ninjamander

Ninjamander

2017-04-23 14:29

reporter   ~0001539

Last edited: 2017-04-23 14:35

View 3 revisions

 here is the old thread of the mod in question : https://forum.zdoom.org/viewtopic.php?f=19&t=32858

link to the most recent : http://allfearthesentinel.net/download?file=sst_v1.4rc7.pk7
the maps in question is sstmap34

And thanks for the info.
Torr Samaho

Torr Samaho

2017-04-23 14:34

manager   ~0001540

I added the necessary entry for Zandronum:

https://bitbucket.org/Torr_Samaho/zandronum/commits/9679b9b67f46e7a2e1285fad036b0c08c6888f60
_mental_

_mental_

2017-04-23 14:35

developer   ~0001541

Last edited: 2017-04-23 14:35

View 2 revisions

 A bit off-topic but with the mentioned compatibility option enabled exiting this map (or rather entering map02) crashes GZDoom.
It appeared that Exit_Normal special has a wrong player start argument. This leads to 'No player 1 start to travel to!' warning here
G_FinishTravel() at g_level.cpp:1260
G_DoLoadLevel(position=1, autosave=true) at g_level.cpp:1022
G_DoWorldDone() at g_level.cpp:1166
G_Ticker() at g_game.cpp:1125
TryRunTics() at d_net.cpp:1951

and then it crashes with the following callstack
AActor::UnlinkFromWorld(this=0x000000011015f600, ctx=0x0000000000000000) at p_maputl.cpp:298
AActor::OnDestroy(this=0x000000011015f600) at p_mobj.cpp:5364
DObject::Destroy(this=0x000000011015f600) at dobject.cpp:379
DThinker::DestroyThinkersInList(list=0x0000000100faabd8) at dthinker.cpp:453
DThinker::DestroyAllThinkers() at dthinker.cpp:432
P_FreeLevelData() at p_setup.cpp:3516
C_FullConsole() at c_console.cpp:1313
G_Ticker() at g_game.cpp:1133
TryRunTics() at d_net.cpp:1951

Value of prev is 0xbeefcafe but 'Woo! Bug-catching value!' comment tells me nothing to be honest.
Graf Zahl

Graf Zahl

2017-04-23 15:44

administrator   ~0001542

It crashed while taking down the level and printing the error message.
That value comes from trying to destroy a partially created thinker chain.

Strange that it crashes, though.

Issue History

Date Modified Username Field Change
2017-04-23 12:18 Ninjamander New Issue
2017-04-23 12:18 Ninjamander File Added: exitBug.wad
2017-04-23 14:09 _mental_ Note Added: 0001537
2017-04-23 14:13 Graf Zahl Note Added: 0001538
2017-04-23 14:14 Graf Zahl Status new => closed
2017-04-23 14:14 Graf Zahl Resolution open => no change required
2017-04-23 14:29 Ninjamander Note Added: 0001539
2017-04-23 14:31 Ninjamander Note Edited: 0001539 View Revisions
2017-04-23 14:34 Torr Samaho Note Added: 0001540
2017-04-23 14:35 _mental_ Note Added: 0001541
2017-04-23 14:35 _mental_ Note Edited: 0001541 View Revisions
2017-04-23 14:35 Ninjamander Note Edited: 0001539 View Revisions
2017-04-23 15:44 Graf Zahl Note Added: 0001542