View Issue Details

IDProjectCategoryView StatusLast Update
0000443Gameplay + OpenGL[All Projects] Bugpublic2017-03-17 10:02
Assigned To 
Status resolvedResolutionfixed 
Summary0000443: DRLA crashes when player gains armor
DescriptionSince at least February 17th (g2.4pre-538-g18925d0), DRLA crashes GZDoom and QZDoom, both 32-bit and 64-bit, if you pick up an armor bonus, or if you equip armor. I also tested the following GZDoom versions and got the same result:

g2.4pre-593-gbb6e667 on February 20th
g2.4pre-620-g10c6b7a on February 25th
g2.4pre-720-gcfda1a4 on March 2nd
g2.4pre-820-ge5a3d22 on March 7th
2.5pre-56-g005e687 on March 16th
q1.4pre-49-ga29e58b1d on March 16th

The only exception was the March 1st build (g2.4pre-711-g0583691), which gave the following error (which I imagine isn't related but I'll add it anyways):
Script error, "doomrl_arsenal_1.05.wad:DECORATE" line 4452:
Expected ',', got 'Species'.

It works as intended in GZDoom 2.3.2. Unfortunately I couldn't find any builds between 2.3.2 and the February 17th build. There's no way I tear this mod apart to figure out exactly what DRLA is doing to cause this crash.
Steps To ReproducePick up any armor bonus, or attempt to equip armor. Class, map, and other inventory seems irrelevant.
TagsNo tags attached.





2017-03-16 21:34

reporter (31,205 bytes)


2017-03-16 21:46

reporter   ~0001028

Also might be worth noting that in DRLA, you're not supposed to be able to pick up armor bonuses at all if you don't have any armor equipped. No idea if the player is actually picking it up and causing the crash, or if it's a script involved in a silly hack that runs when you try.


2017-03-17 08:51

developer   ~0001029

Last edited: 2017-03-17 09:14

View 5 revisions

It began to happen in this commit.
I reproduced it with the following command line by hitting Use key twice after loading:
-iwad doom2 -file doomrl_arsenal_1.05.wad +map map01 +give RLGenericBootsPickup
Or the same crash with armor bonus pickup, just move forward after loading:
-iwad doom2 +map map10 -file doomrl_arsenal_1.05.wad +summon RLArmorBonusPickup

The crash is caused by this change to be precise.
Graf, will be enough to add nullptr check for this block of code?
It works for me but I'm curious about possible side effects.

Graf Zahl

Graf Zahl

2017-03-17 09:54

administrator   ~0001030

I'll have to check for the real problem. Just hiding it by leaving a stale pointer behind is not a good option.
Graf Zahl

Graf Zahl

2017-03-17 10:01

administrator   ~0001031

This code must work differently in ZScript and DECORATE because it is only an error in ZScript.
There's still an underlying problem in the compiled script that had to be relegated to a warning.

Issue History

Date Modified Username Field Change
2017-03-16 21:34 AkiraZXE New Issue
2017-03-16 21:34 AkiraZXE File Added:
2017-03-16 21:46 AkiraZXE Note Added: 0001028
2017-03-17 08:51 _mental_ Note Added: 0001029
2017-03-17 08:56 _mental_ Note Edited: 0001029 View Revisions
2017-03-17 09:00 _mental_ Priority normal => high
2017-03-17 09:00 _mental_ Status new => acknowledged
2017-03-17 09:13 _mental_ Note Edited: 0001029 View Revisions
2017-03-17 09:13 _mental_ Note Edited: 0001029 View Revisions
2017-03-17 09:14 _mental_ Note Edited: 0001029 View Revisions
2017-03-17 09:54 Graf Zahl Note Added: 0001030
2017-03-17 10:01 Graf Zahl Note Added: 0001031
2017-03-17 10:02 Graf Zahl Status acknowledged => resolved
2017-03-17 10:02 Graf Zahl Resolution open => fixed