View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0000443 | Gameplay + OpenGL | [All Projects] Bug | public | 2017-03-16 21:34 | 2017-03-17 10:02 |
Reporter | AkiraZXE | ||||
Assigned To | |||||
Priority | high | Severity | crash | Reproducibility | always |
Status | resolved | Resolution | fixed | ||
Summary | 0000443: DRLA crashes when player gains armor | ||||
Description | Since at least February 17th (g2.4pre-538-g18925d0), DRLA crashes GZDoom and QZDoom, both 32-bit and 64-bit, if you pick up an armor bonus, or if you equip armor. I also tested the following GZDoom versions and got the same result: g2.4pre-593-gbb6e667 on February 20th g2.4pre-620-g10c6b7a on February 25th g2.4pre-720-gcfda1a4 on March 2nd g2.4pre-820-ge5a3d22 on March 7th 2.5pre-56-g005e687 on March 16th q1.4pre-49-ga29e58b1d on March 16th The only exception was the March 1st build (g2.4pre-711-g0583691), which gave the following error (which I imagine isn't related but I'll add it anyways): Script error, "doomrl_arsenal_1.05.wad:DECORATE" line 4452: Expected ',', got 'Species'. It works as intended in GZDoom 2.3.2. Unfortunately I couldn't find any builds between 2.3.2 and the February 17th build. There's no way I tear this mod apart to figure out exactly what DRLA is doing to cause this crash. | ||||
Steps To Reproduce | Pick up any armor bonus, or attempt to equip armor. Class, map, and other inventory seems irrelevant. | ||||
Tags | No tags attached. | ||||
CrashReport.zip (31,205 bytes) |
|
Also might be worth noting that in DRLA, you're not supposed to be able to pick up armor bonuses at all if you don't have any armor equipped. No idea if the player is actually picking it up and causing the crash, or if it's a script involved in a silly hack that runs when you try. | |
It began to happen in this commit. I reproduced it with the following command line by hitting Use key twice after loading:
Or the same crash with armor bonus pickup, just move forward after loading:
The crash is caused by this change to be precise. Graf, will be enough to add nullptr check for this block of code? It works for me but I'm curious about possible side effects. |
|
I'll have to check for the real problem. Just hiding it by leaving a stale pointer behind is not a good option. | |
This code must work differently in ZScript and DECORATE because it is only an error in ZScript. There's still an underlying problem in the compiled script that had to be relegated to a warning. |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2017-03-16 21:34 | AkiraZXE | New Issue | |
2017-03-16 21:34 | AkiraZXE | File Added: CrashReport.zip | |
2017-03-16 21:46 | AkiraZXE | Note Added: 0001028 | |
2017-03-17 08:51 | _mental_ | Note Added: 0001029 | |
2017-03-17 08:56 | _mental_ | Note Edited: 0001029 | View Revisions |
2017-03-17 09:00 | _mental_ | Priority | normal => high |
2017-03-17 09:00 | _mental_ | Status | new => acknowledged |
2017-03-17 09:13 | _mental_ | Note Edited: 0001029 | View Revisions |
2017-03-17 09:13 | _mental_ | Note Edited: 0001029 | View Revisions |
2017-03-17 09:14 | _mental_ | Note Edited: 0001029 | View Revisions |
2017-03-17 09:54 | Graf Zahl | Note Added: 0001030 | |
2017-03-17 10:01 | Graf Zahl | Note Added: 0001031 | |
2017-03-17 10:02 | Graf Zahl | Status | acknowledged => resolved |
2017-03-17 10:02 | Graf Zahl | Resolution | open => fixed |