All Projects Gameplay + OpenGL Software Renderer zdoom.org (Site)

View Issue Details

Jump to NotesIssue History
IDProjectCategoryView StatusDate SubmittedLast Update
0000440Gameplay + OpenGL[All Projects] Bugpublic2017-03-16 01:202017-03-16 12:56
ReporterMatthew the Glutton 
Assigned ToRachael 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Summary0000440: [as of fea2361] Bobbing goes haywire if you alter it on the fly using ZScript
DescriptionIt used to be that you can relatively smoothly transition from one viewbob amount to another. Now if it changes you rapidly jitter up and down.
Steps To ReproduceTried with this build of HD: https://github.com/MatthewTheGlutton/HideousDestructor/tree/5fd04b727b83c032a03b072f464a3c4bb9e1eb7f

Ensure your movebob is set to above zero and at a level you can easily see. Run, sprint, walk around a bit, try walking crouched. Soon you'll start constantly shaking up and down as you try to move.
TagsNo tags attached.

Relationships

Activities

Matthew the Glutton

Matthew the Glutton

2017-03-16 01:24

reporter   ~0001014

Works as intended in 0176c29. I don't see anything in the intervening commits that relate to weapon/viewbob though.
Graf Zahl

Graf Zahl

2017-03-16 12:35

administrator   ~0001021

Last edited: 2017-03-16 12:36

View 3 revisions

 The intervening commits pulled in QZDoom which snuck in a major change to the bobbing code:

    //[SP] Added (x*player->mo->ViewBob) to allow DECORATE changes to view bobbing speed.
    if (still)
    {
        if (player->health > 0)
        {
            angle = level.time / (120 * TICRATE / 35.) * 360. * player->mo->ViewBob;
            bob = player->userinfo.GetStillBob() * angle.Sin();
        }
        else
        {
            bob = 0;
        }
    }
    else
    {
        angle = level.time / (20 * TICRATE / 35.) * 360. * player->mo->ViewBob;
        bob = player->bob * angle.Sin() * (player->mo->waterlevel > 1 ? 0.25f : 0.5f);
    }


Those two multiplications with viewbob were not there before.
Rachael

Rachael

2017-03-16 12:56

administrator   ~0001024

I probably had an improper version sitting in the QZDoom repository when Nash later fixed it.

I just took GZDoom's 2.4 version and stuck it in.

Issue History

Date Modified Username Field Change
2017-03-16 01:20 Matthew the Glutton New Issue
2017-03-16 01:24 Matthew the Glutton Note Added: 0001014
2017-03-16 12:35 Graf Zahl Note Added: 0001021
2017-03-16 12:36 Graf Zahl Assigned To => Rachael
2017-03-16 12:36 Graf Zahl Status new => assigned
2017-03-16 12:36 Graf Zahl Note Edited: 0001021 View Revisions
2017-03-16 12:36 Graf Zahl Note Edited: 0001021 View Revisions
2017-03-16 12:56 Rachael Note Added: 0001024
2017-03-16 12:56 Rachael Status assigned => resolved
2017-03-16 12:56 Rachael Resolution open => fixed