|
|
| Reporter | _mental_ | |
|---|
| Assigned To | | |
|---|
| Priority | high | Severity | major | Reproducibility | always |
|---|
| Status | resolved | Resolution | fixed | |
|---|
|
|
| Summary | 0000300: Broken save/load menu |
|---|
| Description | After scriptification of menus <New Save Game> entry is added to save and load menus as many time as game is saved.
It's possible to crash the game by manipulating with these extra entries. |
|---|
| Steps To Reproduce | 1. Start new game
2. Save
3. Open load menu and notice <New Save Game> entry there
4. Open save menu and notice extra <New Save Game> entry there |
|---|
| Additional Information | The problem lies in changes of TextEnterMenu and SaveMenu cooperation.
Order of calls was swapped here in comparison with native menus.
Now SaveMenu instance can use text stored in TextEnterMenu object however Destroy was never called for the first object because of that.
I think that M_ClearMenus() function can be rewritten like this to fix the problem above:
void M_ClearMenus ()
{
M_DemoNoPlay = false;
while (CurrentMenu != nullptr)
{
DMenu* parent = CurrentMenu->mParentMenu;
CurrentMenu->Destroy();
CurrentMenu = parent;
}
V_SetBorderNeedRefresh();
menuactive = MENU_Off;
}
Although this function called from many places and I cannot say that it's 100% safe to do so. |
|---|
| Tags | No tags attached. |
|---|
|
|
