View Issue Details

IDProjectCategoryView StatusLast Update
0000537Gameplay + OpenGL[All Projects] Bugpublic2017-04-06 06:58
ReporterPsi7 
Assigned To 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Summary0000537: CVAR is UNKNOW in game menu
DescriptionCVARs that have the "user" scope in CVARINFO are broken. This problem appears with all mods that have user CVARs (Samasara, CustomDoom ...)
Steps To ReproduceLoad GZDoom with a mod that can be customized (CustomDoom for example) and open it's configuration.
The CVARs that are unknown in CustomDoom can be found in "Randomizer options". "Show Timer" and the notifications settings will appear as unknown and the slider will not work.

Custom Doom:https://forum.zdoom.org/viewtopic.php?t=51446 (Open the menu with a keybind
TagsNo tags attached.

Relationships

Activities

Psi7

Psi7

2017-04-04 14:42

reporter   ~0001239

Good Ol'Hud is a better example https://forum.zdoom.org/viewtopic.php?f=46&t=54123
Blue Shadow

Blue Shadow

2017-04-05 03:10

reporter   ~0001242

Running 2.5pre-259-g4b127c7, I can confirm that.
_mental_

_mental_

2017-04-05 04:25

developer   ~0001243

Last edited: 2017-04-05 04:25

View 2 revisions

The bug was introduced in this commit with extension of CVar.FindCVar() function.
I think scripting interface should have two functions to access console variables, FindCVar() and GetCVar(), like on C++ side.
Let's wait for Graf's opinion.

Graf Zahl

Graf Zahl

2017-04-05 08:33

administrator   ~0001248

You may be right. That change was probably not the best thing to do for what it was supposed to achieve anyway.
_mental_

_mental_

2017-04-06 02:54

developer   ~0001255

Fixed in 26e4b74
Nash

Nash

2017-04-06 04:43

reporter   ~0001257

Does this mean my previous FindCVar scripting won't work anymore and I have to migrate them to GetCVar?
_mental_

_mental_

2017-04-06 06:58

developer   ~0001258

It depends on usage of player argument.
The functions operate a bit differently under the hood: FindCVar() will return CVar object regardless of IGNORE and USER flags.
For this reason its replacement with GetCVar() broke custom menus.

Issue History

Date Modified Username Field Change
2017-04-04 10:47 Psi7 New Issue
2017-04-04 14:42 Psi7 Note Added: 0001239
2017-04-05 03:10 Blue Shadow Note Added: 0001242
2017-04-05 04:25 _mental_ Note Added: 0001243
2017-04-05 04:25 _mental_ Note Edited: 0001243 View Revisions
2017-04-05 05:02 _mental_ Status new => confirmed
2017-04-05 08:33 Graf Zahl Note Added: 0001248
2017-04-06 02:54 _mental_ Note Added: 0001255
2017-04-06 02:54 _mental_ Status confirmed => resolved
2017-04-06 02:54 _mental_ Resolution open => fixed
2017-04-06 04:43 Nash Note Added: 0001257
2017-04-06 06:58 _mental_ Note Added: 0001258