View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
0000369 | Gameplay + OpenGL | [All Projects] Bug | public | 2017-03-02 11:22 | 2017-03-19 13:38 |
Reporter | PillowBlaster | ||||
Assigned To | |||||
Priority | normal | Severity | minor | Reproducibility | always |
Status | resolved | Resolution | fixed | ||
Summary | 0000369: [SBARINFO] drawinventorybar not responding | ||||
Description | What says on the tin, I guess. Custom inventory bar doesn't pop up while switching items. | ||||
Steps To Reproduce | Tried with this mod. Either fullscreen or normal hud will suffice. Tested with x64-g2.4pre-720-gcfda1a4. Works in x64-2.3.2 official. | ||||
Tags | No tags attached. | ||||
I cannot see any difference between ZDoom 2.8.0, GZDoom 2.3.2 and the latest devbuild. Can you make screenshots of the different behavior? |
|
So this is how it supposed to look, And here's how it fares in newest version. It directly browses through the items without popping the inventory switch bar out. EDIT: It should also be noted that when that isn't defined, you just press use to use the currently selected item, right? Here, the bar isn't visible, yet it acts like it's still "there", so I have to confirm selecting that item by using it. |
|
The issue is present in both master and maint2.4 branches. Inventory bar is missing from the screen indeed. Affected modes are classic HUD (with screenblocks 10 and 11) and alternative HUD (screenblocks 11 only). If I got it right the problem is in ST_X and ST_Y values that are out-of-sync between DSBarInfo object and the wrapper it contains (instance of DBaseStatusBar class). When I changed these lines to use variables from the wrapper the issue disappeared. But all this status bar stuff is far from being straightforward and this fix may potentially hide some more generic issue elsewhere. |
|
And now take one guess why I make no progress with the status bar code. SBARINFO is doing so many weird stuff that it's nearly impossible to develop an adequate replacement. This is a great example of the code fucking around with some internals in totally inappropriate places. Instead of handling it cleanly, it just sets the global position to something different, draws some stuff and resets it immediately. It's downright dirty programming, unfortunately SBARINFO lives and dies with it. |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2017-03-02 11:22 | PillowBlaster | New Issue | |
2017-03-02 11:57 | Graf Zahl | Status | new => feedback |
2017-03-02 11:57 | Graf Zahl | Note Added: 0000840 | |
2017-03-02 13:13 | PillowBlaster | Note Added: 0000841 | |
2017-03-02 13:13 | PillowBlaster | Status | feedback => new |
2017-03-02 13:19 | PillowBlaster | Note Edited: 0000841 | View Revisions |
2017-03-19 09:12 | _mental_ | Note Added: 0001060 | |
2017-03-19 09:13 | _mental_ | Note Edited: 0001060 | View Revisions |
2017-03-19 09:13 | _mental_ | Note Edited: 0001060 | View Revisions |
2017-03-19 09:14 | _mental_ | Status | new => confirmed |
2017-03-19 13:34 | Graf Zahl | Note Added: 0001062 | |
2017-03-19 13:37 | Graf Zahl | Note Edited: 0001062 | View Revisions |
2017-03-19 13:37 | Graf Zahl | Note Edited: 0001062 | View Revisions |
2017-03-19 13:38 | Graf Zahl | Status | confirmed => resolved |
2017-03-19 13:38 | Graf Zahl | Resolution | open => fixed |