All Projects Gameplay + OpenGL Software Renderer zdoom.org (Site)

View Issue Details

Jump to NotesIssue History
IDProjectCategoryView StatusDate SubmittedLast Update
0000030Gameplay + OpenGL[All Projects] Bugpublic2017-01-11 07:422017-01-21 09:13
ReporterEdward-san 
Assigned ToEdward-san 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
PlatformLinuxOSUbuntuOS Version16.04 x86-64
Summary0000030: Link from GZDoom to GL libraries not fully dynamic
DescriptionSee from this to this.
TagsNo tags attached.

Relationships

Activities

Graf Zahl

Graf Zahl

2017-01-11 08:45

administrator   ~0000043

Please do a pull request if you want it changed. On Windows this is a non-issue and I cannot test the Linux code myself.
Edward-san

Edward-san

2017-01-11 11:41

developer   ~0000044

https://github.com/coelckers/gzdoom/pull/213

Needs opinion from Blzut3 and __mental__.
_mental_

_mental_

2017-01-18 10:10

developer   ~0000117

Blzut3, could you please check the latest version of the PR?
Blzut3

Blzut3

2017-01-18 23:02

developer   ~0000129

I can actually test and merge it tomorrow, but visually I don't see anything wrong with the latest version.
Blzut3

Blzut3

2017-01-19 20:04

developer   ~0000142

OK, there is a functional issue in that DYN_GL does nothing. This is because the variable doesn't change anything in gl_load.c.
Edward-san

Edward-san

2017-01-20 04:26

developer   ~0000145

So you mean that I should add a new DYN_OPENGL macro definition and use it in gl_load.c?

If yes, in which part of the expression:

#if defined(__sgi) || defined(__sun) | defined(__unix__)


should I put it?

In any case, I'm not fully convinced we need DYN_GL at all, unless you know about a situation for which it must be disabled?
Blzut3

Blzut3

2017-01-20 16:42

developer   ~0000175

I have no issues with the DYN_GL option just being removed. If someone needs it, they can add it.
Edward-san

Edward-san

2017-01-20 19:57

developer   ~0000176

Updated the pull request.
Rachael

Rachael

2017-01-21 00:25

administrator   ~0000177

Has this been tested on Windows? I am now getting linker errors for unresolved externals, all pointing to gl_load and various other GL files.
Edward-san

Edward-san

2017-01-21 02:01

developer   ~0000178

Last edited: 2017-01-21 02:01

View 2 revisions

 Can you list the unresolved externals?
_mental_

_mental_

2017-01-21 03:45

developer   ~0000181

opengl32.lib and glu32.lib are now missing from linked libraries list.
win32gliface.obj : error LNK2019: unresolved external symbol __imp__wglCreateContext@4 referenced 
in function "public: bool __thiscall Win32GLVideo::InitHardware(struct HWND__ *,int)" (?InitHardware@Win32GLVideo@@QAE_NPAUHWND__@@H@Z)

win32gliface.obj : error LNK2019: unresolved external symbol __imp__wglDeleteContext@4 referenced in 
function "protected: bool __thiscall Win32GLVideo::SetPixelFormat(void)" (?SetPixelFormat@Win32GLVideo@@IAE_NXZ)

win32gliface.obj : error LNK2019: unresolved external symbol __imp__wglGetProcAddress@4 referenced in 
function "public: __thiscall Win32GLFrameBuffer::Win32GLFrameBuffer(void *,int,int,int,int,bool)" 
(??0Win32GLFrameBuffer@@QAE@PAXHHHH_N@Z)
gl_load.obj : error LNK2001: unresolved external symbol __imp__wglGetProcAddress@4
win32gliface.obj : error LNK2019: unresolved external symbol __imp__wglMakeCurrent@8 referenced in function 
"public: bool __thiscall Win32GLVideo::InitHardware(struct HWND__ *,int)" (?InitHardware@Win32GLVideo@@QAE_NPAUHWND__@@H@Z)
Edward-san

Edward-san

2017-01-21 05:14

developer   ~0000182

Does it still happen with this commit?
Rachael

Rachael

2017-01-21 09:02

administrator   ~0000186

@Edward-san: Everything seems to be ok now.

Issue History

Date Modified Username Field Change
2017-01-11 07:42 Edward-san New Issue
2017-01-11 08:45 Graf Zahl Note Added: 0000043
2017-01-11 08:46 Graf Zahl Assigned To => Edward-san
2017-01-11 08:46 Graf Zahl Status new => acknowledged
2017-01-11 11:41 Edward-san Note Added: 0000044
2017-01-12 02:59 Graf Zahl Assigned To Edward-san => _mental_
2017-01-18 10:10 _mental_ Assigned To _mental_ => Blzut3
2017-01-18 10:10 _mental_ Note Added: 0000117
2017-01-18 23:02 Blzut3 Note Added: 0000129
2017-01-19 20:04 Blzut3 Note Added: 0000142
2017-01-19 20:06 Blzut3 Status acknowledged => feedback
2017-01-20 04:26 Edward-san Note Added: 0000145
2017-01-20 04:26 Edward-san Status feedback => assigned
2017-01-20 16:42 Blzut3 Note Added: 0000175
2017-01-20 19:57 Edward-san Status assigned => needs review
2017-01-20 19:57 Edward-san Note Added: 0000176
2017-01-20 22:38 Blzut3 Status needs review => resolved
2017-01-20 22:38 Blzut3 Resolution open => fixed
2017-01-21 00:25 Rachael Status resolved => needs review
2017-01-21 00:25 Rachael Note Added: 0000177
2017-01-21 02:01 Edward-san Note Added: 0000178
2017-01-21 02:01 Edward-san Note Edited: 0000178 View Revisions
2017-01-21 03:45 _mental_ Note Added: 0000181
2017-01-21 05:14 Edward-san Note Added: 0000182
2017-01-21 06:26 Edward-san Assigned To Blzut3 => Edward-san
2017-01-21 06:26 Edward-san Status needs review => needs testing
2017-01-21 09:02 Rachael Note Added: 0000186
2017-01-21 09:13 Rachael Status needs testing => resolved