View Issue Details

IDProjectCategoryView StatusLast Update
0000208Gameplay + OpenGL[All Projects] Bugpublic2017-02-08 16:02
ReporterMajor Cooke 
Assigned To 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Summary0000208: SetCamera doesn't work
Description
DEFINE_ACTION_FUNCTION(AActor, SetCamera)
{
    PARAM_ACTION_PROLOGUE(AActor);
    PARAM_OBJECT(cam, AActor);
    PARAM_BOOL_DEF(revert);

    if (self->player == nullptr || self->player->mo != self) return 0;

    if (camera == nullptr)
    {
        camera = self;
        revert = false;
    }
    AActor *oldcamera = self->player->camera;
    self->player->camera = camera;
    if (revert) self->player->cheats |= CF_REVERTPLEASE;

    if (oldcamera != camera)
    {
        R_ClearPastViewer(camera);
    }
    return 0;
}


Not once is 'cam' used, but 'camera' is. Also the definition inside of SetCamera is also 'cam'.

native void SetCamera(Actor cam, bool revert = false);
TagsNo tags attached.

Relationships

Activities

Major Cooke

Major Cooke

2017-02-08 08:32

reporter   ~0000433

Last edited: 2017-02-08 08:32

View 2 revisions

Fixed it on my end. https://github.com/coelckers/gzdoom/pull/243

Issue History

Date Modified Username Field Change
2017-02-08 07:27 Major Cooke New Issue
2017-02-08 08:32 Major Cooke Note Added: 0000433
2017-02-08 08:32 Major Cooke Note Edited: 0000433 View Revisions
2017-02-08 16:02 Graf Zahl Status new => resolved
2017-02-08 16:02 Graf Zahl Resolution open => fixed