0000143: Make roll interpolation toggleable

ID	Project	Category	View Status	Date Submitted	Last Update

0000143	Gameplay + OpenGL	[All Projects] Feature	public	2017-01-30 07:02	2017-01-30 13:30

Reporter	Major Cooke
Assigned To
Priority	normal	Severity	minor	Reproducibility	have not tried
Status	resolved	Resolution	fixed

Summary	0000143: Make roll interpolation toggleable
Description	In D4D, if you set the bullet trails to Particle Trails, and fire the shotgun, you'll notice some nasty 1-tic momentary roll interpolation. I believe this is why we have A_SetRoll's SPF_INTERPOLATE flag. Can this just be done that way instead of applying it across the board?
Tags	No tags attached.

Major Cooke 2017-01-30 07:06 reporter ~0000288	Specifically, go to D4D Mod Options -> Display Option -> Bullet Tracer Effects option and set it to Particle Trail.

Graf Zahl 2017-01-30 07:14 administrator ~0000289 Last edited: 2017-01-30 07:15 View 2 revisions	Looks like the SPF_INTERPVIEW flag is only affecting the player but not regular actors. The engine code itself is fine, but the implementation of A_SetAngle, A_SetPitch and A_SetRoll do not really disable angular interpolation if not desired. I think I remove the angular interpolation code again, because a quick look shows that the entire engine needs to be reviewed for this which is not really something I want to do.

Nash 2017-01-30 12:42 reporter ~0000292	Ah, what a shame. I was actually about to send a PR that adds interpolation in gl_models.cpp but I realized that it only works for things that are P_Thing_Warp'd and yet player model rotation is STILL jittery. Maybe I could volunteer to take a look at A_SetAngle/Pitch/Roll and see if we can fix this inconsistency once and for all.

Graf Zahl 2017-01-30 13:30 administrator ~0000293	It's not A_Set* what's causing problems but the general assumptzion of the game code that the angle is very liberally modified everywhere. This all needs to be carefully reviewed before it can be activated and right now that simply exceeds the free time I have.

Date Modified	Username	Field	Change
2017-01-30 07:02	Major Cooke	New Issue
2017-01-30 07:06	Major Cooke	Note Added: 0000288
2017-01-30 07:14	Graf Zahl	Note Added: 0000289
2017-01-30 07:15	Graf Zahl	Note Edited: 0000289	View Revisions
2017-01-30 07:46	Graf Zahl	Status	new => resolved
2017-01-30 07:46	Graf Zahl	Resolution	open => fixed
2017-01-30 12:42	Nash	Note Added: 0000292
2017-01-30 13:30	Graf Zahl	Note Added: 0000293