All Projects Gameplay + OpenGL Software Renderer zdoom.org (Site)

View Issue Details

Jump to NotesIssue History
IDProjectCategoryView StatusDate SubmittedLast Update
0000070Gameplay + OpenGL[All Projects] Bugpublic2017-01-18 06:202017-01-18 18:39
ReporterEdward-san 
Assigned To 
PrioritynormalSeverityminorReproducibilityalways
Status resolvedResolutionfixed 
Summary0000070: Wrong loop in P_SetRenderSector
DescriptionIn commit https://github.com/coelckers/gzdoom/commit/b9ac44e8f21a8c751b53aad7f41a44045e9bdc9e , the structure of the loop in P_SetRenderSector got changed, but one inner loop kept the same counter variable as the outer loop, leading to the outer loop to terminate unexpectedly early.

Could this have something to do with all the crashes which happened recently?
Additional InformationNoticed because GCC reported this in Release mode:


/home/edward-san/zdoom/gzdoom/trunk/src/p_glnodes.cpp: In function ‘void P_SetRenderSector()’:
/home/edward-san/zdoom/gzdoom/trunk/src/p_glnodes.cpp:1441:16: warning: assuming signed overflow does 
not occur when assuming that (X + c) >= X is always true [-Wstrict-overflow]
  for (i = 0; i < numsegs; i++)
              ~~^~~~~~~~~
TagsNo tags attached.

Relationships

Activities

Graf Zahl

Graf Zahl

2017-01-18 18:39

administrator   ~0000123

The loops shouldn't be nested at all, they need to run in sequence.

Issue History

Date Modified Username Field Change
2017-01-18 06:20 Edward-san New Issue
2017-01-18 06:22 Edward-san Additional Information Updated View Revisions
2017-01-18 06:26 Edward-san Description Updated View Revisions
2017-01-18 18:39 Graf Zahl Status new => resolved
2017-01-18 18:39 Graf Zahl Resolution open => fixed
2017-01-18 18:39 Graf Zahl Note Added: 0000123