All Projects Gameplay + OpenGL Software Renderer zdoom.org (Site)

View Issue Details

Jump to NotesIssue History
IDProjectCategoryView StatusDate SubmittedLast Update
0000064Gameplay + OpenGL[All Projects] Bugpublic2017-01-16 16:582017-01-22 03:08
ReporterEdward-san 
Assigned To 
PrioritynormalSeveritymajorReproducibilityalways
Status resolvedResolutionfixed 
Summary0000064: [sw renderer] 'vis->Sector' uninitialized in R_DrawVisSprite
DescriptionValgrind report:


==21052== Conditional jump or move depends on uninitialised value(s)
==21052==    at 0x62DF56: swrenderer::R_DrawVisSprite(swrenderer::vissprite_t*) (r_things.cpp:401)
==21052==    by 0x632032: swrenderer::R_DrawPSprite(DPSprite*, AActor*, float, float, double, double, 
double) (r_things.cpp:1538)
==21052==    by 0x6324C5: swrenderer::R_DrawPlayerSprites() (r_things.cpp:1654)
==21052==    by 0x622FA7: swrenderer::R_RenderActorView(AActor*, bool) (r_main.cpp:921)
==21052==    by 0x609F92: FSoftwareRenderer::RenderView(player_t*) (r_swrenderer.cpp:165)
==21052==    by 0x75B207: D_Display() (d_main.cpp:778)
==21052==    by 0x75BB7E: D_DoomLoop() (d_main.cpp:1021)
==21052==    by 0x75D214: D_DoomMain() (d_main.cpp:2678)
==21052==    by 0x5ECDEE: main (i_main.cpp:259)
==21052==  Uninitialised value was created by a heap allocation
==21052==    at 0x4C2DB8F: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==21052==    by 0x4C2FDEF: realloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==21052==    by 0x7976E8: M_Realloc_Dbg(void*, unsigned long, char const*, int) (m_alloc.cpp:150)
==21052==    by 0x6351D0: TArray<swrenderer::vissprite_t, swrenderer::vissprite_t>::DoResize() 
(tarray.h:424)
==21052==    by 0x6349B0: TArray<swrenderer::vissprite_t, swrenderer::vissprite_t>::Reserve(unsigned 
int) (tarray.h:374)
==21052==    by 0x63187D: swrenderer::R_DrawPSprite(DPSprite*, AActor*, float, float, double, double, 
double) (r_things.cpp:1300)
==21052==    by 0x6324C5: swrenderer::R_DrawPlayerSprites() (r_things.cpp:1654)
==21052==    by 0x622FA7: swrenderer::R_RenderActorView(AActor*, bool) (r_main.cpp:921)
==21052==    by 0x609F92: FSoftwareRenderer::RenderView(player_t*) (r_swrenderer.cpp:165)
==21052==    by 0x75B207: D_Display() (d_main.cpp:778)
==21052==    by 0x75BB7E: D_DoomLoop() (d_main.cpp:1021)
==21052==    by 0x75D214: D_DoomMain() (d_main.cpp:2678)
Steps To Reproducevalgrind gzdoom -iwad DOOM2.WAD -warp 01 -nosound
TagsNo tags attached.

Relationships

parent of 0000102 resolved [sw renderer] 'vis->gpos' uninitialized in R_DrawVisSprite 

Activities

Edward-san

Edward-san

2017-01-16 17:08

developer   ~0000104

Forgot to add the gdb backtrace:


#0  0x00000000006a64eb in swrenderer::R_DrawVisSprite (vis=0x1017d8c0) at /home/edward-san/zdoom/gzdoom/trunk/src/r_things.cpp:401
        
frac = 0
        tex = 0x300000000
        x2 = 0
        stop4 = 270531408
        xiscale = 269998444
        mode = (swrenderer::DoDraw0 | swrenderer::DoDraw1)
        ispsprite = false
        centeryfrac = 1
#1  0x00000000006aaa8f in swrenderer::R_DrawPSprite (pspr=0x10200160, owner=0xf971640, bobx=0, boby=0, 
wx=0, wy=32, ticfrac=1) at /home/edward-san/zdoom/gzdoom/trunk/src/r_things.cpp:1538
        tx = 23
        x1 = 329
        x2 = 448
        sx = 0
        sy = 32.375
        sprdef = 0x12020de4
        sprframe = 0x102df040
        picnum = {texnum = 256}
        flip = 0
        tex = 0xf6bbc40
        vis = 0x1017d8c0
        noaccel = false
        avis = {Array = 0x1017d8c0, Count = 1, Most = 16}
        colormap_to_use = 0x2257660 <NormalLight>
0000002  0x00000000006ab04f 
in swrenderer::R_DrawPlayerSprites () at /home/edward-san/zdoom/gzdoom/trunk/src/r_things.cpp:1654
        centerhack = 210
        wy = 32
        boby = 0
        wx = 0
        bobx = 0
        i = -895919595
        lightnum = 112
        psp = 0x10200160
        weapon = 0x10200160
        sec = 0xe654330

Issue History

Date Modified Username Field Change
2017-01-16 16:58 Edward-san New Issue
2017-01-16 17:08 Edward-san Note Added: 0000104
2017-01-17 18:53 Graf Zahl Status new => resolved
2017-01-17 18:53 Graf Zahl Resolution open => fixed
2017-01-22 03:08 Edward-san Relationship added parent of 0000102