All Projects Gameplay + OpenGL Software Renderer zdoom.org (Site)

View Issue Details

Jump to NotesIssue History
IDProjectCategoryView StatusDate SubmittedLast Update
0000346Gameplay + OpenGL[All Projects] Bugpublic2017-02-27 06:302017-02-27 07:53
ReporterSanyaWaffles 
Assigned To 
PrioritynormalSeveritycrashReproducibilityhave not tried
Status resolvedResolutionfixed 
PlatformWindowsOSWindowsOS Version10
Summary0000346: Typo in DamageType definitions code causes crash
Descriptionat line 871, with the introduction of the OBITUARY definition in the MAPINFO way of defining damagetypes, it seems defining a FACTOR value crashes the game unless you change one line of code in info.cpp.
The Error Message:
Script error, "ddrama.pk7:mapinfo/cluster.txt" line 11:
Unexpected data (1.0) in damagetype definition.

I fixed the bug on my own custom build of GZDoom by changing Line 871 to an else if statement like so:
if (sc.Compare("FACTOR"))
{
    sc.MustGetStringName("=");
    sc.MustGetFloat();
    dtd.DefaultFactor = sc.Float;
    if (dtd.DefaultFactor == 0) dtd.ReplaceFactor = true;
}
else if (sc.Compare("OBITUARY"))
{
    sc.MustGetStringName("=");
    sc.MustGetString();
    dtd.Obituary = sc.String;
}

I used gzdoom-x64-g2.4pre-681-gf9f9f2d.7z and dragging and dropping a MAPINFO.txt file (which is just a file from part of my total conversion, albiet renamed) to test this.
Steps To Reproduce1.) Load latest dev-build of GZDoom (gzdoom-x64-g2.4pre-681-gf9f9f2d.7z)
2.) Use ther attached MAPINFO.txt to test the game
3.) drag and drop my modded text-file onto gzdoom dev-build version indicated above
4.) Should crash with a similar error message
TagsNo tags attached.

Relationships

Activities

SanyaWaffles

SanyaWaffles

2017-02-27 06:30

reporter  

MAPINFO.txt (239 bytes) 
// Clusters Block
cluster 1
{
	pic = "INTERPIC"
	music = ""
}
// End Clusters Block

DamageType LavaFloor
{
	Factor = 1.0
}

DamageType RegularNukeSlime
{
	Factor = 1.0
}

DamageType PeptoBloodSlime
{
	Factor = 1.0
}
MAPINFO.txt (239 bytes)

Issue History

Date Modified Username Field Change
2017-02-27 06:30 SanyaWaffles New Issue
2017-02-27 06:30 SanyaWaffles File Added: MAPINFO.txt
2017-02-27 07:53 Graf Zahl Status new => resolved
2017-02-27 07:53 Graf Zahl Resolution open => fixed