All Projects Gameplay + OpenGL Software Renderer zdoom.org (Site)

View Issue Details

Jump to NotesIssue History
IDProjectCategoryView StatusDate SubmittedLast Update
0000415Gameplay + OpenGL[All Projects] Bugpublic2017-03-11 22:382017-03-13 15:23
ReporterTheCamaleonMaligno 
Assigned To 
PrioritynormalSeveritytweakReproducibilityalways
Status resolvedResolutionfixed 
Summary0000415: Using the DontHurtShooter property on ZScript may crash the game
Descriptioni know it's deprecated but at least you can replace the crash with an orange message telling it's deprecated
Steps To Reproducetitle
Additional Informationnot sure in which gzdoom version it started but i think it's from the firsts days of march
TagsGZDoom, ZScript

Relationships

Activities

Rachael

Rachael

2017-03-12 00:25

administrator   ~0000935

Example?
TheCamaleonMaligno

TheCamaleonMaligno

2017-03-12 01:07

reporter   ~0000936

Class FriendlyRocket : Rocket
{
    Default
    {
        DontHurtShooter;
    }
}

i'm currently using this version of gzdoom: gzdoom-x64-g2.4pre-861-gf1630ce
_mental_

_mental_

2017-03-12 05:43

developer   ~0000939

The crash is not related to DontHurtShooter property but to a missing value.
It's certainly a bug in ZScript parser because the crash happens with any other property.
_mental_

_mental_

2017-03-13 15:04

developer   ~0000965

Last edited: 2017-03-13 15:11

View 2 revisions

 Non-boolean properties without a value are still crashing with this fix included:
Class FriendlyRocket : Rocket
{
    Default
    {
        FastSpeed;
    }
}

This was the main reason I didn't fix it by myself: I have alsmost no idea how to handle all kind of errors there.
Graf Zahl

Graf Zahl

2017-03-13 15:23

administrator   ~0000966

Argh!

I really don't understand why Randi had to do these stupid ring lists in the AST. They make processing this stuff needlessly complicated and then lead to error like this one.

Issue History

Date Modified Username Field Change
2017-03-11 22:38 TheCamaleonMaligno New Issue
2017-03-11 22:38 TheCamaleonMaligno Tag Attached: GZDoom
2017-03-11 22:38 TheCamaleonMaligno Tag Attached: ZScript
2017-03-12 00:25 Rachael Note Added: 0000935
2017-03-12 00:25 Rachael Status new => feedback
2017-03-12 01:07 TheCamaleonMaligno Note Added: 0000936
2017-03-12 01:07 TheCamaleonMaligno Status feedback => new
2017-03-12 05:43 _mental_ Note Added: 0000939
2017-03-12 07:13 Rachael Status new => acknowledged
2017-03-13 13:56 Graf Zahl Status acknowledged => resolved
2017-03-13 13:56 Graf Zahl Resolution open => fixed
2017-03-13 13:56 Graf Zahl Additional Information Updated View Revisions
2017-03-13 15:04 _mental_ Note Added: 0000965
2017-03-13 15:04 _mental_ Status resolved => new
2017-03-13 15:04 _mental_ Resolution fixed => reopened
2017-03-13 15:11 _mental_ Note Edited: 0000965 View Revisions
2017-03-13 15:23 Graf Zahl Note Added: 0000966
2017-03-13 15:23 Graf Zahl Status new => resolved
2017-03-13 15:23 Graf Zahl Resolution reopened => fixed